cc @Ladas

Checked commits agrare/manageiq-providers-vmware@c08ab6b~...64b084d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
10 files checked, 13 offenses detected

app/models/manageiq/providers/vmware/infra_manager.rb

• ❗ - Line 37, Col 5 - Rails/InverseOf - Specify an :inverse_of option.

app/models/manageiq/providers/vmware/infra_manager/distributed_virtual_switch.rb

• ❗ - Line 2, Col 3 - Rails/InverseOf - Specify an :inverse_of option.

app/models/manageiq/providers/vmware/infra_manager/inventory/parser/virtual_machine.rb

• ❗ - Line 356, Col 120 - Style/BracesAroundHashParameters - Missing curly braces around a hash parameter.

app/models/manageiq/providers/vmware/infra_manager/refresh_parser.rb

• ⚠️ - Line 107, Col 35 - Lint/UriEscapeUnescape - URI.decode method is obsolete and should not be used. Instead, use CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case.
• ⚠️ - Line 56, Col 11 - Lint/ShadowedArgument - Argument mor was shadowed by a local variable before it was used.
• ⚠️ - Line 58, Col 18 - Lint/UriEscapeUnescape - URI.decode method is obsolete and should not be used. Instead, use CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case.
• ⚠️ - Line 92, Col 27 - Lint/UnusedBlockArgument - Unused block argument - mor. If it's necessary, use _ or _mor as an argument name to indicate that it won't be used.
• ❗ - Line 109, Col 35 - Style/NumericPredicate - Use security_policy.fetch_path('allowPromiscuous', 'value').to_s.casecmp('true').zero? instead of security_policy.fetch_path('allowPromiscuous', 'value').to_s.casecmp('true') == 0.
• ❗ - Line 110, Col 35 - Style/NumericPredicate - Use security_policy.fetch_path('forgedTransmits', 'value').to_s.casecmp('true').zero? instead of security_policy.fetch_path('forgedTransmits', 'value').to_s.casecmp('true') == 0.
• ❗ - Line 111, Col 35 - Style/NumericPredicate - Use security_policy.fetch_path('macChanges', 'value').to_s.casecmp('true').zero? instead of security_policy.fetch_path('macChanges', 'value').to_s.casecmp('true') == 0.
• ❗ - Line 70, Col 66 - Style/NumericPredicate - Use allow_promiscuous.to_s.casecmp('true').zero? instead of allow_promiscuous.to_s.casecmp('true') == 0.
• ❗ - Line 71, Col 65 - Style/NumericPredicate - Use forged_transmits.to_s.casecmp('true').zero? instead of forged_transmits.to_s.casecmp('true') == 0.
• ❗ - Line 72, Col 60 - Style/NumericPredicate - Use mac_changes.to_s.casecmp('true').zero? instead of mac_changes.to_s.casecmp('true') == 0.